Closed nicegamer7 closed 1 year ago
Patch coverage: 100.00%
and project coverage change: +0.01%
:tada:
Comparison is base (
5fdd776
) 93.95% compared to head (e7c7325
) 93.97%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Actually, I'm going to put this on hold until i18next/react-i18next#1663 is resolved, since it might mean we don't have to revert #871.
edit: i18next/react-i18next#1663 was fixed, so there's no need to revert #871 anymore.
Hey @karellm, I just pushed another commit that fixes two more issues that I noticed. The two issues are:
Take a look when you have a chance and let me know if there are any concerns!
LGTM! Thanks for the great work and it is now deployed as 8.7.0
Why am I submitting this PR
After #871, it seems I introduced a regression, though it did help find a bug.
It seems that react-i18next does indeed default the key to theAfter reporting this on react-i18next's bug tracker (i18next/react-i18next#1663), it looks like this was unintended. I fixed that, so no need to revert #871.defaults
prop (I added a comment to prevent anyone from making the same mistake again). I've reverted the changes from #871 to match react-i18next's behavior.Otherwise, it seems we had a bug where we were unescaping values in reverse (i.e. unescaping when it wasn't needed, and not unescaping when it was needed). I corrected this, and also made it so that we always unescape the key, since this matches react-i18next's behavior as well.
Does it fix an existing ticket?
Closes #886.
Checklist
yarn test
(see details here)