search

i18next / i18next-parser

Parse your code to extract translation keys/values and manage your catalog files
MIT License
472 stars 192 forks source link

Changes in order should cause --fail-on-update to fail #926

Closed mspiess closed 8 months ago

mspiess commented 10 months ago

🐛 Bug Report

When the keys are complete but in a wrong order calling i18next --fail-on-update with sort: true in the config does update the files but not fail.

To Reproduce

  1. Have a project with an unsorted translation file and sort: true in the config.
  2. Run i18next --fail-on-update 'src/**/*.{ts,tsx,js,jsx}'

Expected behavior

Expected the command to fail, since there are updates in the translation file.

Your Environment

karellm commented 10 months ago

@mspiess It makes sense. Can you make a PR?

mspiess commented 10 months ago

Yes, I will try to make time on the weekend. Is this a breaking change?

karellm commented 10 months ago

I don't think it is no.

karellm commented 8 months ago

Deployed as 8.11.0