Closed woutervanvliet closed 10 months ago
All modified lines are covered by tests :white_check_mark:
Files | Coverage Δ | |
---|---|---|
src/helpers.js | 92.39% <100.00%> (ø) |
... and 1 file with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.
Why am I submitting this PR
I originally started investigating the Broccoli problems mentioned in #684 on a Windows computer, running with some Danish locale settings. This caused a number of problems, from my editor opening bin/cli.js instead of running the code to sorting and line-ending issues with some tests.
Assuming the assertions to be the one source of truth, I've added a locale parameter in localeCompare for the default comparison function. lineEndings are set to
lf
for a test that checks the entire contents of a generated JSON file.Does it fix an existing ticket?
No
Checklist
yarn test
(see details here)