i18next / ng-i18next

translation for AngularJS using i18next
https://github.com/i18next/ng-i18next
MIT License
161 stars 54 forks source link

TypeScript, rollup.js, es2015, port moved to I18next v2 branch #117

Closed anwalkers closed 8 years ago

anwalkers commented 8 years ago

All I can say is a $filter backed by a $provider that loads its data asynchronously is asking for trouble...

You will need to do the following to get the branch compiling...

npm install -g bower
npm install -g typescript
npm install -g rollup //not sure if this is needed to not
npm install -g typings

npm install
bower install
typings install // This goes away with TypeScript 2.0

gulp ci

You know the rest of the drill. I was using VS Code as my editor, but all the major editors have TypeScript Support.

I am going to try upgrading my application to use the code from my repo and see how it goes. I'll let you know the result

anwalkers commented 8 years ago

I have all the example, unit tests, and have this library integrated in my application from my forked git code repo. The biggest change was removing the initialization of i18next out of the provider and onto the window prior to bootstrapping angular. It is a much cleaner solution. I am going to update the documentation in my fork for the developers in my organization. They will be using the forked version until this is potentially merged.

Someone will need to add the typescript, typings, and rollup.js to the build process if you want to have a green build. I can do it if I can get contributor rights.

Andy

anwalkers commented 8 years ago

I got the build green. I am updating the docs...

bugwelle commented 8 years ago

Wow, awesome :+1: I was on vacation for the last week, so I did'n have the time to merge this. Thank you very much :)