search

i18next / ng-i18next

translation for AngularJS using i18next
https://github.com/i18next/ng-i18next
MIT License
161 stars 54 forks source link

Updated Angular to version 1.2.6 #27

Closed pahlers closed 10 years ago

pahlers commented 10 years ago

Tests: Safari 7.0 (Mac): Executed 40 of 40 SUCCESS (0.507 secs / 0.241 secs) PhantomJS 1.9 (Mac): Executed 40 of 40 SUCCESS (0.546 secs / 0.26 secs) Firefox 25.0 (Mac): Executed 40 of 40 SUCCESS (0.805 secs / 0.304 secs) Chrome 33.0 (Mac): Executed 40 of 40 SUCCESS (0.664 secs / 0.398 secs) Chrome 34.0 (Mac): Executed 40 of 40 SUCCESS (0.758 secs / 0.35 secs) TOTAL: 200 SUCCESS

bugwelle commented 10 years ago

Thank you very much! :) I'll merge this PR. :+1: But the version change of ng-i18next isn't really necessary, is it?

pahlers commented 10 years ago

Np. I don't know when you have to change the version number. Do you have any idea's?

Do you want an PR without version change?

bugwelle commented 10 years ago

Ok, it's not necessary to change the version number since the ng-i18next code has not changed :) I'll merge this later and change the version back to 0.2.8

Thanks, Andre