search

i18next / ng-i18next

translation for AngularJS using i18next
https://github.com/i18next/ng-i18next
MIT License
161 stars 54 forks source link

remove blatant LIE from the README (oops) #51

Closed putermancer closed 10 years ago

putermancer commented 10 years ago

I realized at lunch that one of the examples I added to the README was completely inaccurate -- it would have been accurate if we checked for defaultLoadingValue first, but that is not the way it works currently.

bugwelle commented 10 years ago

That was one issue I thought about when merging the latest pull requests... I think the behaviour you described in README should be correct. Maybe we should change the code that is responsible for that. :) I'll look at this again this afternoon ;)

bugwelle commented 10 years ago

ng-i18next now looks for options.defaultLoadingValue first ;) So your documentation is just fine.

putermancer commented 10 years ago

Awesome, thanks for your help, our projects now use ~0.3.3 again instead of our custom form and things are working great!

bugwelle commented 10 years ago

I'm glad to hear that ;)