i18next / ng-i18next

translation for AngularJS using i18next
https://github.com/i18next/ng-i18next
MIT License
161 stars 54 forks source link

remove useless $digest #56

Closed efolio closed 10 years ago

efolio commented 10 years ago

This $digest is useless and breaks my tests without any good reason. Unless there is a very good reason to let it be, I suggest we remove it.

bugwelle commented 10 years ago

Thank you. This should be fixed with 809112935ed2db013842a03d231dbb6a0eeac3c9 :) //Update, no, isn't fixed...

Regards, Andre

efolio commented 10 years ago

No, it is not the same $digest :)

bugwelle commented 10 years ago

Ooops, I think I was a little bit too fast... Sorry :D

bugwelle commented 10 years ago

I reverted this because of some problems with i18next filter. But I'll look into this again.