search

i18next / ng-i18next

translation for AngularJS using i18next
https://github.com/i18next/ng-i18next
MIT License
161 stars 54 forks source link

Latest commit breaks "directives" test :/ #8

Closed julien51 closed 11 years ago

julien51 commented 11 years ago

Hello, I'm not sure the latest commit 6f48a0b is 'final' but it breaks the "directives" test, which works fine in b453e03.

Maybe we should write better tests? Do you want me to do so? I'm not familiar with how to do it since it will depend on the language used by the tester, but maybe you have a better idea?

Please, let me know!

Thanks

bugwelle commented 11 years ago

Yeah, I haven't looked at all tests...

To solve your problem, simply comment these lines out:

I didn't want to compile the content of the element, when there isn't an expression inside. I also didn't look after directives...

Well, it would be great to use Grunt and use gruntfile.jsand write tests for it.

You don't have to translate the strings to German ;) If you want to add some strings to translate, just don't add the strings to the German language file.