search

i18next / ng-i18next

translation for AngularJS using i18next
https://github.com/i18next/ng-i18next
MIT License
161 stars 54 forks source link

jQuery $ as a global variable #82

Closed jairovsky closed 9 years ago

jairovsky commented 9 years ago

Hi!

Reading i18next's code (https://github.com/i18next/i18next/blob/master/i18next.js#L93) I found that, when jQuery is a global, i18next registers itself inside jQuery's $, and not inside window.

Problem is that, currently, ng-i18next only verifies if i18next is registered into window (see https://github.com/i18next/ng-i18next/blob/master/src/provider.js#L21).

Is there a possibility to fix this?

jairovsky commented 9 years ago

Really sorry for opening this issue. After some more research I found that i18next registers for both $ and window, and I'm actually being affected by #81. This has nothing to do with jQuery.