i2-wustl / visualization-ui

0 stars 0 forks source link

refactoring params to json #42

Closed itlackey closed 4 years ago

DennisGoldfarb commented 4 years ago

Looks good and worked in my hands. Out of curiosity, what's with some of the div's getting separated into different lines? Although it's not my preference, it's even worse when it's inconsistent :p one or the other is fine with me.

ricardo-rodriguez1 commented 4 years ago

Although I agree with Dennis that we should not split div's, I'm going to approve the PR. I'm ok with splitting other html elements if they have multiple attributes that will not fit in a line (for sake of readability; ex: Inputs). For next PR that touches these files, we should move the Div's back to one line for consistency. Other than that, things work as expected.