search

i2a2 / irioCoreCpp

https://i2a2.github.io/irioCoreCpp/
GNU General Public License v3.0
2 stars 1 forks source link

More resources than supported in some tests #2

Open victorcostap opened 8 months ago

victorcostap commented 8 months ago

Original tests of irio-v2 (https://github.com/i2a2/irio-v2) "TEST(TP_FlexRIO_onlyResources, onlyResources)" checks if all the resoures of a bitfile are detected correctly. In this case, there are 54 DI and 54 DO.

In irio-v2-cpp the limit of digital terminals (the combined number of DI and DO) for FlexRIO is 90, which are less than the number of digital terminals defined in the test above, which causes an exception with the error: "More Digital terminals than supported"

The commit related to the issue at date of this issue's creation : 02e8094d9a5336f97fa19a60b25ad10574a02d42

Should the new library implement a hard restriction with the number of terminals or let the user use as much as possible?

victorcostap commented 8 months ago

For the time being, disable enforcing this artificial limitation as it wasn't really enforced in the original irio-v2 driver. Commit with the workaround ff1eb0dfe82e5afef274c61b298b169d83ec992f