search

i2group / notebook-sdk

Create plug-ins that expand and enhance the functionality of the i2 Notebook web client by using the i2 Notebook SDK. The SDK is comprised of documentation, tools, and sample code.
https://i2group.github.io/notebook-sdk/
MIT License
4 stars 1 forks source link

Seemingly incorrect proxy command in the README.md #18

Closed Cmoore-i2 closed 4 months ago

Cmoore-i2 commented 4 months ago

Whilst following the README.md instructions the command npx @i2analyze/notebook-sdk-plugin-proxy --config devproxy.json fails. To be more specific, the command itself doesn't fail in the terminal but at the address the terminal output gives eg http://localhost:4000/ none of the changes are displayed there, the plugin appears to not have been loaded.

Running npx @i2analyze/notebook-sdk-plugin-proxy@dev --config devproxy.json instead appears to fix this issue. I'd raise a PR but it's not possible for me.

Anthony-Johnson-i2 commented 4 months ago

Hi @Cmoore-i2 Cameron

As you are internal to i2 you can also ask this sort of question on the Ask-i2 internal teams channel or you can talk to the dev team who work on this directly. (It is also useful for such observations to be seen here as well where others might benefit too :-) )

There is a process we have for managing internally found issues whether they are documentation problems or code issues and these alter dependant on whether we feel customers might be affected or not and whether the issue is found by a member of R&D or not.

I'll let the dev team know and they can decide whether to interact with you here or via teams etc.

Cheers

Tim-Mawson-i2 commented 4 months ago

Closing this as the issue is fixed, pending release.

Anthony-Johnson-i2 commented 4 months ago

Excellent ! Thanks @Tim-Mawson-i2