i2p / i2p.i2p

I2P is an anonymizing network, offering a simple layer that identity-sensitive applications can use to securely communicate. All data is wrapped with several layers of encryption, and the network is both distributed and dynamic, with no trusted parties.
https://geti2p.net
Other
1.95k stars 305 forks source link

Hamcrest and Junit references added #11

Closed lpadgett closed 6 years ago

lpadgett commented 7 years ago

Added Hamcrest (all, 1.3) and JUnit (4.12) references into the .iml files of all the apps (along with the installer and core) so the matchers and test code (especially the stuff in core/java/test/junit) could run.

Edit: Previously, the .iml files had no references to hamcrest, and in some cases JUnit too, which would pose difficulties/errors for testing and running i2p (depending on the part of i2p being executed)

holzingk commented 7 years ago

This repository is updated only by an hourly cronjob which exports our monotone repository. We will have to apply this manually using diff probably. See https://geti2p.net/en/get-involved/guides/new-developers#git

majestrate commented 7 years ago

java i2p uses monotone inside of the i2p network for their main development code

github is a mirror of that.

holzingk commented 7 years ago

I am going to squash your two commits and prepare a patch and submit it into our bugtracker.

holzingk commented 7 years ago

https://trac.i2p2.de/ticket/1891

lpadgett commented 7 years ago

Understood, majestrate. I will be using monotone for i2p contributions from now on.

Thanks, nextl00p!

str4d commented 6 years ago

Sorry for not addressing this sooner! I have actually just removed the .iml files, because we now have a Gradle build script for generating them (./gradlew idea). Please test that, and open a new issue if you still have problems 🙂