codecov-io
commented
6 years ago Codecov Report
Merging #14 into master will increase coverage by
<.01%. The diff coverage is0%.
@@ Coverage Diff @@
## master #14 +/- ##
============================================
+ Coverage 6.39% 6.39% +<.01%
+ Complexity 2264 2263 -1
============================================
Files 1236 1236
Lines 131098 131097 -1
Branches 25173 25173
============================================
+ Hits 8385 8386 +1
- Misses 121258 121260 +2
+ Partials 1455 1451 -4| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| ...pps/susimail/src/src/i2p/susi/webmail/WebMail.java | 0% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
| core/java/src/net/i2p/crypto/DSAEngine.java | 28.73% <0%> (-1.12%) |
28% <0%> (-2%) |
|
| router/java/src/net/i2p/router/time/NtpClient.java | 28.31% <0%> (-0.89%) |
4% <0%> (-2%) |
|
| core/java/src/net/i2p/util/RandomSource.java | 48.35% <0%> (+1.09%) |
8% <0%> (+1%) |
:arrow_up: |
| core/java/src/net/i2p/crypto/ElGamalEngine.java | 66.66% <0%> (+1.19%) |
9% <0%> (+1%) |
:arrow_up: |
| ...e/java/src/gnu/crypto/prng/BasePRNGStandalone.java | 64.58% <0%> (+6.25%) |
11% <0%> (+1%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0ba0f1b...09387a7. Read the comment docs.
majestrate
PimpTrizkit
holzingk
1) When viewing the main info screen of a torrent in I2PSnark, if that torrent's root consists of all folders and no files, then the Priority buttons at the bottom will not be visible. However, somewhere in the code, I have not found where yet but it still calls "setupbuttons()" even tho there are no buttons to setup. Therefore, it crashes in the browser. A very inconsequential bug; as there is no more code to run afterwards. But who likes seeing red lines in the console. a) Simply fixed by softening "setupbuttons()" up a little, with a check for existence of the "savepri" button. So now, if the code accidentally throws a call to either of these two functions "setupbuttons()" and "priorityclicked()"... it won't crash. 2) While I was here I decided to also "Modernize" the code a little with the new-er JavaScript standard. LET declarations and the arrow functions are lighter-weight. Also, I trimmed up the FOR loops and IF statements. a) I quickened up the loops. unified variable declarations, cached out length and data array, got rid of post-expression in the FOR loop in favor of in-line, on an existing expression. b) For the "updatesetallbuttons()", I used Short-Circuit logic, once all three are found, no need to keep searching. I inverted the booleans around to make more sense (if notNorm is true.. then its true that we don't want the Norm button) and to avoid using nots ("!"). c) Trimmed nested IF statements into one with short circuit operator (&&)... (same pseudo logic). d) Removed some IF statements in favor of the more concise ternary operator (?:).... (same pseudo logic).
---- Or you can just ignore most all of this and just add an IF statement in "setupbuttons()" before calling "updatesetallbuttons()".