i3 / i3lock

improved screen locker
https://i3wm.org/i3lock
BSD 3-Clause "New" or "Revised" License
921 stars 404 forks source link

Alteration of login failed message and font size #126

Closed vishwajithsandaru closed 7 years ago

vishwajithsandaru commented 7 years ago

"Wrong" message for an incorrect password is changed to "access denied", and the font size is reduced.

Airblader commented 7 years ago

Putting aside that the commits are broken and include two independent changes... What are the reasons for these changes?

vishwajithsandaru commented 7 years ago

In practical its better to say "access denied" and looks professional than "wrong" during a login failure to a computer, but when the message is changed to "access denied" the default font size seems to be too large and there is a lack of space to some of the letters and they are going out of the field, so I reduced the font size littlebit.

Airblader commented 7 years ago

In practical its better to say "access denied" than "wrong"

That's just restating your change, it doesn't give an argument. We currently return the information PAM gives us, I see no reason to change this.

vishwajithsandaru commented 7 years ago

Sorry for the inconvenience , actually I stated a common problem that arose from user experiences in my area. If you are able could you please explain me the thing with the authentication module - "We currently return the information PAM gives us" ...

Airblader commented 7 years ago

If you are able could you please explain me the thing with the authentication module - "We currently return the information PAM gives us" ...

That was actually a mistake on my side. :-) It's not the PAM result, just our internal status. Still, I feel that "Access Denied", as it stands, is inconsistent with the other texts we display ("locking…", "verifying…", "lock failed!") and I don't see a convincing reason for any change other than personal preference.

Airblader commented 7 years ago

I'm going to close this for now for the mentioned reasons.