Splitting image loading out of the main file, and adding JPEG support.

i3 / i3lock

improved screen locker

https://i3wm.org/i3lock

BSD 3-Clause "New" or "Revised" License

921 stars 404 forks source link

Splitting image loading out of the main file, and adding JPEG support. #157

Closed Cynary closed 5 years ago

Cynary commented 6 years ago

See #68 for discussion and context.

Also did some cleanup:

Repeated string.h header include in i3lock.c;
We were not destroying the cairo surface;

Also revamped error management during image loading. We won't get out of memory errors for invalid types anymore. Fixes #114

Finally, added libjpeg dependency.

stapelberg commented 6 years ago

Thanks for sending this PR.

The complexity of the JPEG-related code confirms my intuition that I don’t feel comfortable maintaining this in the context of i3lock. I think this should either go into cairo upstream or into a third-party library which would ideally be used by many, not just i3lock.

I’d still be interested in the remaining cleanups you did, so if you’d like to submit these as a separate PR, that’d be appreciated!