Switch to autotools - Githubissues

i3 / i3lock

improved screen locker

https://i3wm.org/i3lock

BSD 3-Clause "New" or "Revised" License

921 stars 404 forks source link

Closed stapelberg closed 6 years ago

stapelberg commented 6 years ago

This was largely copied from the i3 configure.ac and Makefile.am.

cc @jasperla @kaashif — I haven’t tested this on non-Linux, so if you could test this, that’d be appreciated.

Airblader commented 6 years ago

Obviously not going to review all the details of this. :-)

stapelberg commented 6 years ago

I’m going to go ahead and merge this. Feedback for non-linux still very welcome, but now in form of a pull request please :).

jasperla commented 6 years ago

This mostly looks fine on OpenBSD, except for two small issues:

it explicitly checks for iconv_open() which fails. it seems there is upstream documentation on the topic. Perhaps i3lock (and i3 too for that matter) should use the more portable approach of AM_ICONV()?
pam is unconditionally linked in (pull request)

stapelberg commented 6 years ago

Thanks for looking. Pull requests for both issues welcome :)