search

i3 / i3lock

improved screen locker
https://i3wm.org/i3lock
BSD 3-Clause "New" or "Revised" License
921 stars 404 forks source link

Unnecessary pointer check #176

Closed valkheim closed 6 years ago

valkheim commented 6 years ago

Hi,

According to xcb documentation, xcb_connect() always return a non-NULL pointer. The comparison to NULL on line 810 looks unnecessary.

This is how monsterwm-xcb implements it : https://github.com/Cloudef/monsterwm-xcb/blob/master/monsterwm.c#L1260

SegFault42 commented 6 years ago

Hi,

Code corrected, Pull Request submitted.

Thank you for your report.

eplanet commented 6 years ago

Just to be precise: will be corrected by pending PR #177. :-)