search

i3 / i3lock

improved screen locker
https://i3wm.org/i3lock
BSD 3-Clause "New" or "Revised" License
921 stars 404 forks source link

return value corrected #177

Closed SegFault42 closed 6 years ago

SegFault42 commented 6 years ago

xcb_connect function never return NULL (see the man here : https://xcb.freedesktop.org/manual/group__XCB__Core__API.html#ga094470586356d1764e69c9a1882966c3)

"Callers need to use xcb_connection_has_error() to check for failure."

Airblader commented 6 years ago

I was wondering at first whether this had changed over time since I don't recall ever seeing a (serious) X11 client using XCB that doesn't check this; however, at least awesome also doesn't check it, so combined with the documentation I assume this should be OK.