search

i3 / i3lock

improved screen locker
https://i3wm.org/i3lock
BSD 3-Clause "New" or "Revised" License
921 stars 404 forks source link

Execute a command when a maximum of auth-attempts is exceeded #190

Closed jroeger23 closed 6 years ago

jroeger23 commented 6 years ago

This branch added the commandline options "-x" and "-m". With "-x" a command is specified, which will be executed, if the maximum ammount of authorization attempts is exceeded. The option "-m" is used to set the maximum allowed retries.

Airblader commented 6 years ago

Hi, thanks for the PR. We generally recommend that you first open an issue so we can discuss potential features before implementing them in case we'd like to not add it to i3lock.

Since it's too late for that, let's discuss it here. What usecase did you have in mind for the command you added? Also, wouldn't it be better to handle monitoring of the authentication within the software that handles that, namely pam?

jroeger23 commented 6 years ago

Hi, thanks for your response. I had in mind, that it would be useful on portable devices, so the device may shut down (in case of an encrypted disk) or somehow log unwanted access attempts. I didn't mind pam, that would be a much better way to achieve this. So it's probably not the right way to let i3lock handle this. (Sorry for directly openign a PR, I'm not really active on github)