search

i3 / i3lock

improved screen locker
https://i3wm.org/i3lock
BSD 3-Clause "New" or "Revised" License
921 stars 404 forks source link

added wm_class property #218

Closed ivanvig closed 5 years ago

ivanvig commented 5 years ago

Right now i3lock has only a wm_name property but lacks of wm_class which is useful to, for example, set compton rules for i3lock's window.

Airblader commented 5 years ago

Thanks for the PR! I'm definitely in favor of adding this, but I think we could do entirely without the new macros here as they just add a level of redirection when reading the code that we don't need. Could you remove them and just use string literals instead? Be carefull for the length of "i3lock\0i3lock\0" to use 2 * (strlen("i3lock") + 1).

Also, please squash the commits into a single commit (and force-push the branch) and drop a comment here so that we get notified. Thank you!

ivanvig commented 5 years ago

I think is done, went back to master and only added the code block corresponding to the property

Airblader commented 5 years ago

Thank you!