search

i3 / i3lock

improved screen locker
https://i3wm.org/i3lock
BSD 3-Clause "New" or "Revised" License
921 stars 404 forks source link

unlock indicator optimization #224

Closed hissssst closed 4 years ago

hissssst commented 5 years ago

Small unlock indicator optimization was made. Now indicator updates only the area in the center of the screen, as it was requested in the comment in the code

Airblader commented 5 years ago

@hissssst Please also squash your changes into one (or more, but meaningful) commits. Thanks! :-)

McKean commented 4 years ago

out of curiosity, will this hit master anytime soon? Just asking as I'm running dual 4k screens and the delays are quite significant. Now I'm not sure if I should clone and install vs. update via package manager. Thanks!

stapelberg commented 4 years ago

out of curiosity, will this hit master anytime soon? Just asking as I'm running dual 4k screens and the delays are quite significant. Now I'm not sure if I should clone and install vs. update via package manager. Thanks!

Are you already using commit https://github.com/i3/i3lock/commit/467e46c077a5b7e38aca28e8a43da9bd393713ff? That made things faster for me.

If yes, could you please build i3lock with this unlock indicator change and confirm that it helps?

McKean commented 4 years ago

Will do! Need to head back where my second monitor is, but I'll report back.

McKean commented 4 years ago

@stapelberg looks like I was still using i3-lock-next and have not properly setup my prime gpu offloading. After switching back to vanilla i3lock and configuring my gpus properly the lag is gone! Thanks for the quick response. And thanks for the amazing locker.

stapelberg commented 4 years ago

@hissssst is this no longer relevant?

Did you notice if this optimization made any noticeable/measurable difference?

(Sorry that reviews are going slow currently.)