Review django-password-policies-validator main ê意見

[sih4sing5hong5]

1.

password_policies.password_validation.ComplexityValidator，檔名一般會號做password_policies.validation.ComplexityValidator'

2

password_policies/settings_checkmigrations.py無需要包tī pypi，而且應該閣有別ê檔案，所以django試驗設定檔另外一ê檔案簿仔就好。

3 參數

https://github.com/i3thuan5/django-password-policies-validator/blob/a9d7121dbcb6f5ca5d935863e4fed84b997be9ce/password_policies/password_validation.py#L9

參數照django-axesê做法，攏用getattr(settings, 'PASSWORD_POLICIES_MIN_CHAR_TYPES', default=4)設定， 抑是django有另外建議？

4 Symbol

SYMBOL用[^0-9a-zA-Z]敢會較好bat？抑是有其他考慮？

[niauah]

1

password_policies.password_validation.ComplexityValidator，檔名一般會號做password_policies.validation.ComplexityValidator'

檔名我是參考Django 本底--ê：'django.contrib.auth.password_validation.UserAttributeSimilarityValidator'。

2

2d9661d 已經改掉--ah。

3

Django本底的validator mā是用OPTIONS 傳--ê，設定方式說明：Enabling password validation

    {
        'NAME': 'django.contrib.auth.password_validation.MinimumLengthValidator',
        'OPTIONS': {
            'min_length': 9,
        }
    },

Django 針對ka-tī設計validator ê說明：Writing your own validator

Any items in the OPTIONS in AUTH_PASSWORD_VALIDATORS for your validator will be passed to the constructor. All constructor arguments should have a default value.

[sih4sing5hong5]

1~3了解，3 ê寫法確實較好，kā validator kah設定寫做伙～

[niauah]

4

eb34d7b 改好--ah。

[sih4sing5hong5]

Aray~