i40-Tools / I40KG

Contains the development for the Industry 4.0 standards knowledge graph (I40KG). Its current collaborative development is driven by VoCol - http://vocol.iais.fraunhofer.de/sto/
64 stars 24 forks source link

Organizations should be linked to Countries #9

Closed igrangel closed 6 years ago

igrangel commented 6 years ago

The Organization Instances, e.g., MIIT should be linked the Country they belong.

mubeequreshi commented 6 years ago

Added country information for organization.

igrangel commented 6 years ago

Could you point at least one line of code when this adding was done?

mubeequreshi commented 6 years ago

Irlan can you please bit elaborate a context "at least one line of code when this adding was done" I did not understand it.

igrangel commented 6 years ago

Click here

mubeequreshi commented 6 years ago

Oka.Thankx

mubeequreshi commented 6 years ago

updated structure of countries

igrangel commented 6 years ago

For example, in which line?

mubeequreshi commented 6 years ago

https://github.com/i40-Tools/StandardsVocabulary/commit/6e28d10f0ada6c5386b0d60a190527ade9ec9815

igrangel commented 6 years ago

You don't have to create Country instances in the ontology, .e.g., https://github.com/i40-Tools/StandardsVocabulary/blob/6e28d10f0ada6c5386b0d60a190527ade9ec9815/sto.ttl#L61, but to reuse existing datasets like DBpedia.

igrangel commented 6 years ago

Also, check please the definitions of the domain and ranges of this property - https://github.com/i40-Tools/StandardsVocabulary/blob/6e28d10f0ada6c5386b0d60a190527ade9ec9815/sto.ttl#L43

mubeequreshi commented 6 years ago

Yes ,I have update them with Dpedia datasets of country so I don't need to create own instance of country and also I have removed following geo vocab properties. https://github.com/i40-Tools/StandardsVocabulary/blob/6e28d10f0ada6c5386b0d60a190527ade9ec9815/sto.ttl#L43

igrangel commented 6 years ago

The Countries should not be part of the STO Ontology like in this case. Cases like the above mentioned should be deleted and only the reference included and the DBPedia namespace in the head.

mubeequreshi commented 6 years ago

updated countries information by using dbpedia resources