search

i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

Notebooks are fixed for testing #490

Closed Lukas113 closed 1 year ago

Lukas113 commented 1 year ago

Currently, all Notebook tests are failing (see action). This needs to be fixed as soon as possible.

image

Lukas113 commented 1 year ago

The notebook tests failed because they didn't find an according ipykernel. I fixed this issue. However, when the notebooks run on the github runners, they get an exit code 143, so basically a kill-command. I'm not entirely sure why this is happening, the error message of the github action isn't looking helpful to me. The PR #491 removes the notebook-tests from the CI/CD pipeline because of the reasons mentioned.

The notebooks however should be tested. In the meantime, I suggest that the notebooks should be tested locally by setting export RUN_SLOW_TESTS=true if changes were made in a notebook or the public karabo API.