i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

Line Emission: Default to equally spaced bins in frequency space #493

Closed lmachadopolettivalle closed 1 year ago

lmachadopolettivalle commented 1 year ago

Per #433 add support for channels equally spaced in frequency space, and use this as the default. Also, added tests for the conversions between frequency and redshift for the 21cm line.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 77.77% and project coverage change: -0.05% :warning:

Comparison is base (1dcd434) 68.72% compared to head (adfe033) 68.67%. Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #493 +/- ## ========================================== - Coverage 68.72% 68.67% -0.05% ========================================== Files 34 34 Lines 3757 3761 +4 Branches 474 475 +1 ========================================== + Hits 2582 2583 +1 - Misses 999 1001 +2 - Partials 176 177 +1 ``` | [Files Changed](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds) | Coverage Δ | | |---|---|---| | [karabo/simulation/line\_emission.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL3NpbXVsYXRpb24vbGluZV9lbWlzc2lvbi5weQ==) | `66.66% <77.77%> (-0.73%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.