search

i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

369 test notebooks #503

Closed Lukas113 closed 1 year ago

Lukas113 commented 1 year ago

closes #369

Lukas113 commented 1 year ago

TODO: adapting tests, bugifxing according to pytest

I hope it doesn't brake something because there were a lot of changes. Even if the thest succeed, we don't know for sure since the coverage is not that high. However, I think once this PR is accepted, we should have a much better file- and dir-management than we had before.Then, we finally can remove from Karabo created directories and files safely in a convenient way.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 76.45% and project coverage change: +0.15% :tada:

Comparison is base (b52ac1a) 68.54% compared to head (50f573c) 68.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #503 +/- ## ========================================== + Coverage 68.54% 68.69% +0.15% ========================================== Files 35 35 Lines 3805 3907 +102 Branches 481 496 +15 ========================================== + Hits 2608 2684 +76 - Misses 1009 1026 +17 - Partials 188 197 +9 ``` | [Files Changed](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds) | Coverage Δ | | |---|---|---| | [karabo/imaging/imager.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL2ltYWdpbmcvaW1hZ2VyLnB5) | `60.68% <55.88%> (+0.05%)` | :arrow_up: | | [karabo/sourcedetection/result.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL3NvdXJjZWRldGVjdGlvbi9yZXN1bHQucHk=) | `58.06% <57.89%> (-1.26%)` | :arrow_down: | | [karabo/simulation/visibility.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL3NpbXVsYXRpb24vdmlzaWJpbGl0eS5weQ==) | `37.07% <60.00%> (+2.55%)` | :arrow_up: | | [karabo/simulation/pinocchio.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL3NpbXVsYXRpb24vcGlub2NjaGlvLnB5) | `70.79% <64.70%> (-0.89%)` | :arrow_down: | | [karabo/util/file\_handler.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL3V0aWwvZmlsZV9oYW5kbGVyLnB5) | `77.38% <77.38%> (ø)` | | | [karabo/simulation/telescope.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL3NpbXVsYXRpb24vdGVsZXNjb3BlLnB5) | `87.87% <86.66%> (-0.68%)` | :arrow_down: | | [karabo/simulation/beam.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL3NpbXVsYXRpb24vYmVhbS5weQ==) | `37.84% <90.90%> (+0.51%)` | :arrow_up: | | [karabo/simulation/interferometer.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL3NpbXVsYXRpb24vaW50ZXJmZXJvbWV0ZXIucHk=) | `81.30% <95.65%> (+1.48%)` | :arrow_up: | | [karabo/imaging/image.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL2ltYWdpbmcvaW1hZ2UucHk=) | `53.37% <100.00%> (-1.78%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.