i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

Remove PINOCCHIO from dependencies #521

Closed lmachadopolettivalle closed 1 year ago

lmachadopolettivalle commented 1 year ago

We have agreed to remove PINOCCHIO from the Karabo package, since it was causing issues with its OpenMPI dependency. We will still have the separate PINOCCHIO fork in i4Ds, but it will not be included as part of Karabo installation, and can be used instead as a separate package.

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (eaaeb53) 73.84% compared to head (18340a5) 73.79%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #521 +/- ## ========================================== - Coverage 73.84% 73.79% -0.05% ========================================== Files 35 34 -1 Lines 3907 3614 -293 ========================================== - Hits 2885 2667 -218 + Misses 1022 947 -75 ``` | [Files](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/521?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds) | Coverage Δ | | |---|---|---| | [karabo/error.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/521?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL2Vycm9yLnB5) | `100.00% <ø> (ø)` | | | [karabo/version.py](https://app.codecov.io/gh/i4Ds/Karabo-Pipeline/pull/521?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-a2FyYWJvL3ZlcnNpb24ucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.