Closed lmachadopolettivalle closed 12 months ago
Another note:
You have used a Python3.10 type-annotation feature. To do a Union with |
is just allowed from Python3.10, and we're operating on Python3.9 at the moment. The reason why Pylance is not complaining is because there is a from __future__ import annotations
at the start of the file. However, it's still not a valid operator in Python3.9. That's the reason why mypy
is complaining.
Attention: 17 lines
in your changes are missing coverage. Please review.
Comparison is base (
2bb1733
) 74.04% compared to head (a003ca1
) 73.16%.
Files | Patch % | Lines |
---|---|---|
karabo/simulation/telescope.py | 76.71% | 17 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Implement changes described in #421 for the
Telescope
Class.SimulatorBackend
enumTelescope
instance. Now, users can call e.g.Telescope.constructor("MeerKAT")
instead of the more hard-codedTelescope.get_MEERKAT_Telescope()
plot_telescope
to take into account which backend is being usedconstructor
method