i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

Telescope Class: Accept OSKAR and RASCIL backends #522

Closed lmachadopolettivalle closed 10 months ago

lmachadopolettivalle commented 11 months ago

Implement changes described in #421 for the Telescope Class.

Lukas113 commented 10 months ago

Another note:

You have used a Python3.10 type-annotation feature. To do a Union with | is just allowed from Python3.10, and we're operating on Python3.9 at the moment. The reason why Pylance is not complaining is because there is a from __future__ import annotations at the start of the file. However, it's still not a valid operator in Python3.9. That's the reason why mypy is complaining.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (2bb1733) 74.04% compared to head (a003ca1) 73.16%.

Files Patch % Lines
karabo/simulation/telescope.py 76.71% 17 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #522 +/- ## ========================================== - Coverage 74.04% 73.16% -0.88% ========================================== Files 34 35 +1 Lines 3614 3652 +38 ========================================== - Hits 2676 2672 -4 - Misses 938 980 +42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.