i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

Vt parallise source detection #523

Closed kenfus closed 10 months ago

kenfus commented 11 months ago
codecov[bot] commented 10 months ago

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (f1e3cc2) 72.91% compared to head (94b8fa9) 74.96%.

Files Patch % Lines
karabo/sourcedetection/result.py 75.00% 39 Missing :warning:
karabo/imaging/image.py 96.34% 3 Missing :warning:
karabo/util/dask.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #523 +/- ## ========================================== + Coverage 72.91% 74.96% +2.04% ========================================== Files 35 35 Lines 3652 3859 +207 ========================================== + Hits 2663 2893 +230 + Misses 989 966 -23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kenfus commented 10 months ago

Overall nice changes.

Before merging, please address the requested changes.

Done! Please have another look.

kenfus commented 10 months ago

@Lukas113 Please have another look. I would like to later restructure source detection completely, see #528