i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

Source Detection is restructured #528

Open kenfus opened 12 months ago

kenfus commented 12 months ago

Currently, Source Detection is quite wierd:

Thing should be split:

Other improvements:

Lukas113 commented 2 months ago

I don't agree with the first part of your complaints. using cls is common and better practice than using the class itself to allow inheritance.

However, I agree to split the classes in SourceDetection and SourceDetectionResult.

If cleanup is still an issue, should also be handled properly.