Open kenfus opened 12 months ago
I don't agree with the first part of your complaints. using cls is common and better practice than using the class itself to allow inheritance.
However, I agree to split the classes in SourceDetection
and SourceDetectionResult
.
If cleanup is still an issue, should also be handled properly.
Currently, Source Detection is quite wierd:
detected sources in image
on a class calledSourceDetectionResult
, which returns itself, but this time with the detected sources as an attribute.cls
makes maybe the code more clean but overall less readable.Thing should be split:
SourceDetection
, which resultsSourceDetectionResult
with the results.Other improvements: