i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

SkyModel Class: Accept OSKAR and RASCIL backends #544

Closed lmachadopolettivalle closed 7 months ago

lmachadopolettivalle commented 7 months ago

Implement changes described in https://github.com/i4Ds/Karabo-Pipeline/issues/421 for the SkyModel Class.

After a design discussion on 08.02.2024 with @Lukas113 and @kenfus we decided on the following approach:

This design choice allows users to benefit from existing code in Karabo to load, filter and visualize SkyModel instances, while also allowing for RASCIL-specific interferometry later in the pipeline.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 66.03%. Comparing base (e0517ae) to head (400bec4). Report is 4 commits behind head on main.

Files Patch % Lines
karabo/simulation/sky_model.py 82.05% 7 Missing :warning:
karabo/simulation/line_emission.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #544 +/- ## ========================================== + Coverage 65.76% 66.03% +0.27% ========================================== Files 47 49 +2 Lines 4504 4796 +292 ========================================== + Hits 2962 3167 +205 - Misses 1542 1629 +87 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.