Closed lmachadopolettivalle closed 7 months ago
Attention: Patch coverage is 85.45455%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 66.03%. Comparing base (
e0517ae
) to head (400bec4
). Report is 4 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
karabo/simulation/sky_model.py | 82.05% | 7 Missing :warning: |
karabo/simulation/line_emission.py | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Implement changes described in https://github.com/i4Ds/Karabo-Pipeline/issues/421 for the SkyModel Class.
After a design discussion on 08.02.2024 with @Lukas113 and @kenfus we decided on the following approach:
numpy
array, inspired by the OSKAR data formatSkyModel
to export sources as a list of RASCILSkyComponents
, which can then be used to compute visibilities and later dirty imagesThis design choice allows users to benefit from existing code in Karabo to load, filter and visualize SkyModel instances, while also allowing for RASCIL-specific interferometry later in the pipeline.