i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

Keep track of BeamPattern within Telescope, not within InterferometerSimulation #559

Open lmachadopolettivalle opened 6 months ago

lmachadopolettivalle commented 6 months ago

BeamPattern is currently instantiated within InterferometerSimulation, but it is more accurately a property of any given Telescope. Per @sfiruch 's suggestion, we should instead create and keep track of BeamPattern instances within the Telescope class.

Additionally, BeamPattern seems to be only used within long observations. We should look into using it for normal observations (i.e. those generated with Observation instances instead of ObservationLong).