i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

562 mals #566

Closed Lukas113 closed 5 months ago

Lukas113 commented 5 months ago

closes #562

Lukas113 commented 5 months ago

@lmachadopolettivalle do you know if the J2000 source ids have a proper specification? If yes, I can probably improve the parsing a lot. I haven't found anything on the web.

I've changed to parsing to meet the following format-specification: (J|+|-)(DD|HH)MMSS(.s+)* Is this fine?

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 98.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.22%. Comparing base (ed7c293) to head (0066dcf).

Files Patch % Lines
karabo/simulation/sky_model.py 97.87% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #566 +/- ## ========================================== + Coverage 66.92% 67.22% +0.29% ========================================== Files 48 48 Lines 4995 5043 +48 ========================================== + Hits 3343 3390 +47 - Misses 1652 1653 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lmachadopolettivalle commented 5 months ago

@lmachadopolettivalle do you know if the J2000 source ids have a proper specification? If yes, I can probably improve the parsing a lot. I haven't found anything on the web.

I've changed to parsing to meet the following format-specification: (J|+|-)(DD|HH)MMSS(.s+)* Is this fine?

As far as I have seen, this is not a standard format for RA and Dec. The main formats I am familiar with are described here, so I believe we need the conversion methods you wrote above. https://docs.astropy.org/en/stable/coordinates/index.html#coordinate-access

Lukas113 commented 5 months ago

@lmachadopolettivalle do you know if the J2000 source ids have a proper specification? If yes, I can probably improve the parsing a lot. I haven't found anything on the web. I've changed to parsing to meet the following format-specification: (J|+|-)(DD|HH)MMSS(.s+)* Is this fine?

As far as I have seen, this is not a standard format for RA and Dec. The main formats I am familiar with are described here, so I believe we need the conversion methods you wrote above. https://docs.astropy.org/en/stable/coordinates/index.html#coordinate-access

Ok. Then I hope the conversion function is good enough for the common use-cases. As far as I've seen this function should work at least for the gleam, mightee and mals survey, tested on example conversions for each survey.