Closed Lukas113 closed 5 months ago
@lmachadopolettivalle do you know if the J2000 source ids have a proper specification? If yes, I can probably improve the parsing a lot. I haven't found anything on the web.
I've changed to parsing to meet the following format-specification: (J|+|-)(DD|HH)MMSS(.s+)* Is this fine?
Attention: Patch coverage is 98.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 67.22%. Comparing base (
ed7c293
) to head (0066dcf
).
Files | Patch % | Lines |
---|---|---|
karabo/simulation/sky_model.py | 97.87% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@lmachadopolettivalle do you know if the J2000 source ids have a proper specification? If yes, I can probably improve the parsing a lot. I haven't found anything on the web.
I've changed to parsing to meet the following format-specification: (J|+|-)(DD|HH)MMSS(.s+)* Is this fine?
As far as I have seen, this is not a standard format for RA and Dec. The main formats I am familiar with are described here, so I believe we need the conversion methods you wrote above. https://docs.astropy.org/en/stable/coordinates/index.html#coordinate-access
@lmachadopolettivalle do you know if the J2000 source ids have a proper specification? If yes, I can probably improve the parsing a lot. I haven't found anything on the web. I've changed to parsing to meet the following format-specification: (J|+|-)(DD|HH)MMSS(.s+)* Is this fine?
As far as I have seen, this is not a standard format for RA and Dec. The main formats I am familiar with are described here, so I believe we need the conversion methods you wrote above. https://docs.astropy.org/en/stable/coordinates/index.html#coordinate-access
Ok. Then I hope the conversion function is good enough for the common use-cases. As far as I've seen this function should work at least for the gleam, mightee and mals survey, tested on example conversions for each survey.
closes #562
SkySourcesUnits.get_pos_ids_to_ra_dec
to convert J2000 sky-source-ids to RA-DEC in degrees