search

i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

addressed mypy issues due to matplotlib update :clock430: #591

Closed Lukas113 closed 4 months ago

Lukas113 commented 4 months ago

mypy updated their type-hints which lead to mypy breaking changes (not API).

Our CI-tests were failing due to this issue and this stopped other PR to be accepted.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 47.91667% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.39%. Comparing base (f9c2508) to head (773a54c).

Files Patch % Lines
karabo/simulation/signal/plotting.py 0.00% 16 Missing :warning:
karabo/simulation/beam.py 62.50% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #591 +/- ## ========================================== - Coverage 67.50% 67.39% -0.12% ========================================== Files 51 51 Lines 5185 5204 +19 ========================================== + Hits 3500 3507 +7 - Misses 1685 1697 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.