i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

typo correction PR :tropical_drink: #599

Closed Lukas113 closed 2 months ago

Lukas113 commented 2 months ago

I was conflicted what to do about the polarization. I wanted to change everything to polarization, but some API's are British English and not American. However, usually we (and most other libraries) use American English. I kept it British atm. Maybe wrong decision?

I also didn't change everything, because I was afraid of breaking some code. This PR was just meant to be an easy fix-typo thing.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 68.52%. Comparing base (b8c415a) to head (fdc8b8b).

Files Patch % Lines
karabo/simulation/signal/galactic_foreground.py 0.00% 4 Missing :warning:
karabo/simulation/signal/plotting.py 0.00% 2 Missing :warning:
karabo/util/dask.py 33.33% 2 Missing :warning:
karabo/imaging/imager_oskar.py 66.66% 1 Missing :warning:
karabo/simulation/interferometer.py 66.66% 1 Missing :warning:
karabo/simulation/sky_model.py 75.00% 1 Missing :warning:
karabo/sourcedetection/evaluation.py 93.75% 1 Missing :warning:
karabo/sourcedetection/result.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #599 +/- ## ======================================= Coverage 68.52% 68.52% ======================================= Files 54 54 Lines 5646 5646 ======================================= Hits 3869 3869 Misses 1777 1777 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mpluess commented 2 months ago

I was conflicted what to do about the polarization. I wanted to change everything to polarization, but some API's are British English and not American. However, usually we (and most other libraries) use American English. I kept it British atm. Maybe wrong decision?

I also didn't change everything, because I was afraid of breaking some code. This PR was just meant to be an easy fix-typo thing.

Probably fine to leave it for now.