Closed anawas closed 1 month ago
Attention: Patch coverage is 66.66667%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 68.61%. Comparing base (
c1aed2c
) to head (597c889
).
Files | Patch % | Lines |
---|---|---|
karabo/simulation/signal/seg_u_net_segmentation.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'll wait for the review until #601 is merged since #601 is also in this PR.
@anawas can you merge main into this branch and solve the conflicts? i will review it after that's done.
@mpluess Done, tests successful
Could do it for OSKAR telescopes. However, plotting a RASCIL instrument works differently. The function Telescope::plt_telescope() can not create a file for RASCIL. The call in the RASCIL package is:
plot_configuration(config, ax=None, plot_file=None, title='Configuration', label=False, **kwargs)
Long story short: I have to rewritte the function in class Telescope.
Changes look good so far, tests are failing though
That's what I talked about on Slack. I did not touch the file the pre-commit hook is complaining about. I ran the tests locally and they passed. This pre-commit hook is bit of hard to deal with.
That's what I talked about on Slack. I did not touch the file the pre-commit hook is complaining about. I ran the tests locally and they passed. This pre-commit hook is bit of hard to deal with.
I seems hard to have 100 % the same environment as the CI tests on GitHub. I think all of us devs have had to fix things in reaction to tests failing on GitHub before. Had to remove the same "type: ignore" comment in another branch this morning. One difference is probably that on GitHub, a new environment is created on every action, meaning our dev envs are probably a bit behind on same package versions. Updating the environment more often could open.
read_OSKAR_tm_file
now works.test/test_telescope.py
. They usedplot_telescope()
in order test if the Telescope instance was created successfully. This took a lot fo time, especially when only this test was run. The test functions now test other telescope specific values.