search

i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA
https://i4ds.github.io/Karabo-Pipeline/
MIT License
11 stars 4 forks source link

Improve src net rucio script #612

Closed Lukas113 closed 2 months ago

Lukas113 commented 3 months ago

closes #611

According to the SRCNet efforts, a demo to create ObsCore metadata and ingest it into the ingestion daemon is needed. Therefore I adapted the SRCNet_rucio_meta.py example script to be a full simulation. This will be helpful for future dataset creation.

In addition, I also discovered a bug by accident, which I described in #611 and is solved in this PR.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.63%. Comparing base (1ea7392) to head (2feefba). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
karabo/imaging/image.py 80.95% 4 Missing :warning:
karabo/data/obscore.py 57.14% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #612 +/- ## ======================================= Coverage 68.62% 68.63% ======================================= Files 53 53 Lines 5696 5713 +17 ======================================= + Hits 3909 3921 +12 - Misses 1787 1792 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Lukas113 commented 2 months ago

@sfiruch I've tested the script and it worked. However, there was an odd output file created in my cwd, not sure from where and why. I've only provided output-filenames instead of default FileHandler handling.