Casa MS file path args should support Visibility class

i4Ds / Karabo-Pipeline

The Karabo Pipeline can be used as Digital Twin for SKA

https://i4ds.github.io/Karabo-Pipeline/

MIT License

11 stars 4 forks source link

Casa MS file path args should support Visibility class #616

Closed Lukas113 closed 1 month ago

Lukas113 commented 2 months ago

This issue originates from PR #612 where we had a discussion about whether ImageCleaner.create_cleaned_image should be a Visibility object or not. Lookup on discussion details can be looked up in the PR.

The TLDR is make visibility args positonal-only and accept casa MS and Visibility. This is an API breaking change.

mpluess commented 2 months ago

Assigned myself since I wanted to address this anyway in #595