i4Ds / STIXCore

STIX Core functionalities
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Improve formatting of the the QL spectra #294

Closed samaloney closed 1 year ago

samaloney commented 1 year ago

This PR fixes a small issue with the formatting of the the QL detector spectra and improves some other aspects of the data product.

codecov-commenter commented 1 year ago

Codecov Report

Base: 80.85% // Head: 80.88% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (bfae1bd) compared to base (432419b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #294 +/- ## ========================================== + Coverage 80.85% 80.88% +0.02% ========================================== Files 62 63 +1 Lines 5927 6271 +344 ========================================== + Hits 4792 5072 +280 - Misses 1135 1199 +64 ``` | [Impacted Files](https://codecov.io/gh/i4Ds/STIXCore/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds) | Coverage Δ | | |---|---|---| | [stixcore/products/level0/quicklookL0.py](https://codecov.io/gh/i4Ds/STIXCore/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-c3RpeGNvcmUvcHJvZHVjdHMvbGV2ZWwwL3F1aWNrbG9va0wwLnB5) | `84.75% <100.00%> (-0.04%)` | :arrow_down: | | [stixcore/processing/publish.py](https://codecov.io/gh/i4Ds/STIXCore/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-c3RpeGNvcmUvcHJvY2Vzc2luZy9wdWJsaXNoLnB5) | `81.28% <0.00%> (ø)` | | | [stixcore/io/fits/processors.py](https://codecov.io/gh/i4Ds/STIXCore/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-c3RpeGNvcmUvaW8vZml0cy9wcm9jZXNzb3JzLnB5) | `75.96% <0.00%> (+0.20%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

samaloney commented 1 year ago

Good question I'll have to look into it

samaloney commented 1 year ago

So the change in the time are real as best I can tell the data is now in good shape so going to merge.