i4Ds / STIXCore

STIX Core functionalities
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

HK aspect comments #335

Closed nicHoch closed 1 year ago

nicHoch commented 1 year ago

adding columns description but also dpdd notes that the aspect diode voltages are aggregated

end2end test failed as expected as a new comment is stored in the extension header and everything is shifted afterwards.

also updates the FILENAME keyword in case of any sub1/2 while publishing

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.11 :warning:

Comparison is base (7699217) 76.98% compared to head (0d93a14) 76.87%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #335 +/- ## ========================================== - Coverage 76.98% 76.87% -0.11% ========================================== Files 63 63 Lines 6562 6596 +34 ========================================== + Hits 5052 5071 +19 - Misses 1510 1525 +15 ``` | [Impacted Files](https://codecov.io/gh/i4Ds/STIXCore/pull/335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds) | Coverage Δ | | |---|---|---| | [stixcore/processing/publish.py](https://codecov.io/gh/i4Ds/STIXCore/pull/335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-c3RpeGNvcmUvcHJvY2Vzc2luZy9wdWJsaXNoLnB5) | `80.64% <36.84%> (-2.00%)` | :arrow_down: | | [stixcore/processing/pipeline\_status.py](https://codecov.io/gh/i4Ds/STIXCore/pull/335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-c3RpeGNvcmUvcHJvY2Vzc2luZy9waXBlbGluZV9zdGF0dXMucHk=) | `28.57% <75.00%> (+28.57%)` | :arrow_up: | | [stixcore/processing/pipeline.py](https://codecov.io/gh/i4Ds/STIXCore/pull/335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-c3RpeGNvcmUvcHJvY2Vzc2luZy9waXBlbGluZS5weQ==) | `72.60% <100.00%> (+0.11%)` | :arrow_up: | | [stixcore/products/level0/housekeepingL0.py](https://codecov.io/gh/i4Ds/STIXCore/pull/335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-c3RpeGNvcmUvcHJvZHVjdHMvbGV2ZWwwL2hvdXNla2VlcGluZ0wwLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.