search

i4Ds / STIXCore

STIX Core functionalities
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Handle cases where SPICE pointing information is not available #356

Closed samaloney closed 1 year ago

samaloney commented 1 year ago

Add try catch around rotation matrix calculation and if not available set roll, yaw and pitch to nans.

samaloney commented 1 year ago

Test fails seem unrelated.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% :tada:

Comparison is base (6dd8193) 76.99% compared to head (74e77d4) 77.02%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #356 +/- ## ========================================== + Coverage 76.99% 77.02% +0.02% ========================================== Files 63 63 Lines 6599 6607 +8 ========================================== + Hits 5081 5089 +8 Misses 1518 1518 ``` | [Files Changed](https://app.codecov.io/gh/i4Ds/STIXCore/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds) | Coverage Δ | | |---|---|---| | [stixcore/ephemeris/manager.py](https://app.codecov.io/gh/i4Ds/STIXCore/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i4Ds#diff-c3RpeGNvcmUvZXBoZW1lcmlzL21hbmFnZXIucHk=) | `91.44% <100.00%> (+0.31%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samaloney commented 1 year ago

Around this line https://github.com/i4Ds/STIXCore/blob/6dd81930999b971ae4606fa9226deaefbe3361e1/stixcore/products/level2/housekeepingL2.py#L289 or in general? We don't really handle other kinds of missing spice information so I'm not sure.

nicHoch commented 1 year ago

no the for each "file" loop here: https://github.com/i4Ds/STIXCore/blob/6dd81930999b971ae4606fa9226deaefbe3361e1/stixcore/products/level2/housekeepingL2.py#L256

but this is more general failure handle. so i can do it also in a dedicated PR