search

i4Ds / STIXCore

STIX Core functionalities
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Various small fixes for data release #375

Closed samaloney closed 10 months ago

samaloney commented 11 months ago

Fixes:

  1. Actually calculate the Carrington coordinate frame values and use in the headers, closes #355
  2. Fix casting issue with fits ext for energy table, closes #359
  3. Remove num_energy_groups, closes #367
  4. Remove energy extension from QL Calibration data, close #338
codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b94f0f8) 78.45% compared to head (54a76b2) 77.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #375 +/- ## ========================================== - Coverage 78.45% 77.79% -0.66% ========================================== Files 65 65 Lines 6775 6777 +2 ========================================== - Hits 5315 5272 -43 - Misses 1460 1505 +45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samaloney commented 11 months ago

E2E differences look as expected to me but 2nd look would be good.