search

i4Ds / STIXCore

STIX Core functionalities
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Add support for trigger scaling in compression mode S=0,k=0,M=7 #377

Closed samaloney closed 10 months ago

samaloney commented 10 months ago

Unscale trigger data when compressed with mode S=0,k=0,M=7

When compressed with mode 0,0,7 the trigger are scaled by the FSW according to T_s = T / (n_int * n_acc * factor) this scaling is removed by the GSW.

Closes #365

samaloney commented 10 months ago

This will need to be rebased on #375 once merged to fix the CI tests.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a801e54) 77.79% compared to head (b31c64a) 76.81%. Report is 1 commits behind head on master.

Files Patch % Lines
stixcore/products/level0/quicklookL0.py 64.70% 6 Missing :warning:
stixcore/products/level0/scienceL0.py 64.70% 6 Missing :warning:
stixcore/products/common.py 93.75% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #377 +/- ## ========================================== - Coverage 77.79% 76.81% -0.99% ========================================== Files 65 66 +1 Lines 6777 6900 +123 ========================================== + Hits 5272 5300 +28 - Misses 1505 1600 +95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samaloney commented 10 months ago

Not to sure about the E2E test fails not related but wasn't expecting them either ...

samaloney commented 10 months ago

Yea well I was able to produce fits files, I tried to compare the triggers from the QL lightcurve, background and spectra and they didn't match but hard to know if they should based on the different detector masks etc so until we get real data not much more can be done.