i4Ds / STIXCore

STIX Core functionalities
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

DATAMIN, DATAMAX and BUNIT in FITS header for each product #394

Closed nicHoch closed 4 days ago

nicHoch commented 5 months ago

'DATAMIN'  > 'Minimum valid physical value'
'DATAMAX' > 'Maximum valid physical value'
'BUNIT' > 'Units of physical value, after application of BSCALE, BZERO'

are fits header keywords used by SOAR for user filtering... as some products have multiple data-streams we have to decide for the "most interesting one"

so fare we only provide real values for count data


'DATAMIN'  =  max('counts')
'DATAMAX' = max('counts')
'BUNIT' = "counts"

open to decide: currently proposals

samaloney commented 1 month ago

It would be really usefull to add explain, expmax for the shortest and longest exposure time too.

nicHoch commented 1 month ago

i added a "XPOMAX" keyword with the longest exposure time: self.data['timedel'].as_float().max().to_value('s')

samaloney commented 1 month ago

To #393 or somewhere else?