Closed apfritts closed 1 year ago
hey @i6mi6 , can we get this merged please? your lib isn't usable with the latest react native version, it fails builds.
+1 to this I'm completely blocked on this unfortunately
+1 to this I'm completely blocked on this unfortunately
I ended up "resolving" the issue by applying the following patch that you can use the patch-package for. The good thing is since it's a React native patch it will work for any library with this issue not just this one:
diff --git a/node_modules/react-native/index.js b/node_modules/react-native/index.js
index d59ba34..8023167 100644
--- a/node_modules/react-native/index.js
+++ b/node_modules/react-native/index.js
@@ -435,32 +435,16 @@ module.exports = {
},
// Deprecated Prop Types
get ColorPropType(): $FlowFixMe {
- invariant(
- false,
- 'ColorPropType has been removed from React Native. Migrate to ' +
- "ColorPropType exported from 'deprecated-react-native-prop-types'.",
- );
+ return require("deprecated-react-native-prop-types").ColorPropType
},
get EdgeInsetsPropType(): $FlowFixMe {
- invariant(
- false,
- 'EdgeInsetsPropType has been removed from React Native. Migrate to ' +
- "EdgeInsetsPropType exported from 'deprecated-react-native-prop-types'.",
- );
+ return require("deprecated-react-native-prop-types").EdgeInsetsPropType
},
get PointPropType(): $FlowFixMe {
- invariant(
- false,
- 'PointPropType has been removed from React Native. Migrate to ' +
- "PointPropType exported from 'deprecated-react-native-prop-types'.",
- );
+ return require("deprecated-react-native-prop-types").PointPropType
},
get ViewPropTypes(): $FlowFixMe {
- invariant(
- false,
- 'ViewPropTypes has been removed from React Native. Migrate to ' +
- "ViewPropTypes exported from 'deprecated-react-native-prop-types'.",
- );
+ return require("deprecated-react-native-prop-types").ViewPropTypes
},
};
+1 to this I'm completely blocked on this unfortunately
I ended up "resolving" the issue by applying the following patch that you can use the patch-package for. The good thing is since it's a React native patch it will work for any library with this issue not just this one:
diff --git a/node_modules/react-native/index.js b/node_modules/react-native/index.js index d59ba34..8023167 100644 --- a/node_modules/react-native/index.js +++ b/node_modules/react-native/index.js @@ -435,32 +435,16 @@ module.exports = { }, // Deprecated Prop Types get ColorPropType(): $FlowFixMe { - invariant( - false, - 'ColorPropType has been removed from React Native. Migrate to ' + - "ColorPropType exported from 'deprecated-react-native-prop-types'.", - ); + return require("deprecated-react-native-prop-types").ColorPropType }, get EdgeInsetsPropType(): $FlowFixMe { - invariant( - false, - 'EdgeInsetsPropType has been removed from React Native. Migrate to ' + - "EdgeInsetsPropType exported from 'deprecated-react-native-prop-types'.", - ); + return require("deprecated-react-native-prop-types").EdgeInsetsPropType }, get PointPropType(): $FlowFixMe { - invariant( - false, - 'PointPropType has been removed from React Native. Migrate to ' + - "PointPropType exported from 'deprecated-react-native-prop-types'.", - ); + return require("deprecated-react-native-prop-types").PointPropType }, get ViewPropTypes(): $FlowFixMe { - invariant( - false, - 'ViewPropTypes has been removed from React Native. Migrate to ' + - "ViewPropTypes exported from 'deprecated-react-native-prop-types'.", - ); + return require("deprecated-react-native-prop-types").ViewPropTypes }, };
You deserve all the kudos in the world, this saved my ass thank you!
` In react native version - 0.72.0 in index.js file we have same line of code you have provided above still its showing same error
this line of code
diff --git a/node_modules/react-native/index.js b/node_modules/react-native/index.js
index d59ba34..8023167 100644
--- a/node_modules/react-native/index.js
+++ b/node_modules/react-native/index.js
@@ -435,32 +435,16 @@ module.exports = {
},
// Deprecated Prop Types
get ColorPropType(): $FlowFixMe {
- invariant(
- false,
- 'ColorPropType has been removed from React Native. Migrate to ' +
- "ColorPropType exported from 'deprecated-react-native-prop-types'.",
- );
+ return require("deprecated-react-native-prop-types").ColorPropType
},
get EdgeInsetsPropType(): $FlowFixMe {
- invariant(
- false,
- 'EdgeInsetsPropType has been removed from React Native. Migrate to ' +
- "EdgeInsetsPropType exported from 'deprecated-react-native-prop-types'.",
- );
+ return require("deprecated-react-native-prop-types").EdgeInsetsPropType
},
get PointPropType(): $FlowFixMe {
- invariant(
- false,
- 'PointPropType has been removed from React Native. Migrate to ' +
- "PointPropType exported from 'deprecated-react-native-prop-types'.",
- );
+ return require("deprecated-react-native-prop-types").PointPropType
},
get ViewPropTypes(): $FlowFixMe {
- invariant(
- false,
- 'ViewPropTypes has been removed from React Native. Migrate to ' +
- "ViewPropTypes exported from 'deprecated-react-native-prop-types'.",
- );
+ return require("deprecated-react-native-prop-types").ViewPropTypes
},
};
Platforms affected
All
What does this PR do?
RN 0.68 has deprecated and will eventually remove
ViewPropTypes
(see post). This adds thedeprecated-react-native-prop-types
package and uses that instead.What testing has been done on this change?
Local testing, to ensure the deprecation warning has been removed.