search

i6mi6 / react-native-parallax-scroll-view

A ScrollView-like component with parallax and sticky header support.
ISC License
2.3k stars 379 forks source link

My unofficial fork with cherry picked PRs #78

Open fungilation opened 7 years ago

fungilation commented 7 years ago

As this repo is most useful and beautiful, it's a shame PRs aren't being tended. I've just made a PR fixing React.PropTypes warnings since RN 0.45 (#77), and merged 2 other great PRs I want in my own app: #57 and #70.

EDIT: Also merged #81, #109

Use my fork if you find it useful: https://github.com/fungilation/react-native-parallax-scroll-view

mini-eggs commented 7 years ago

Ah shoot, just went through the trouble of sending a PR for prop types.

fungilation commented 7 years ago

Manually merged #81 from upstream: Changed animation to use native driver (performance!)

patheinen commented 6 years ago

Perfect - Thanks 👍

gabrielbull commented 6 years ago

Maybe @i6mi6 can add @fungilation as a collaborator?

i6mi6 commented 6 years ago

@gabrielbull I added @fungilation as a collaborator. Thanks!

fungilation commented 6 years ago

@i6mi6 thanks. What's the best course of action for merging my fork. Just do it (merging my fork) would be much easier than redo-ing all the associated PRs here. #81 is already merged here so my fork would have to resolve merge conflict if any for same changes that's already merged.

i6mi6 commented 6 years ago

@fungilation How many PRs are fixed in your fork?

fungilation commented 6 years ago

What I referenced here. All tested working in my own app.

Li357 commented 6 years ago

@i6mi6 @fungilation Any chance of updating the examples in your fork? I can do an update, which can fix https://github.com/i6mi6/react-native-parallax-scroll-view/issues/101.

flikQ commented 6 years ago

@fungilation I forked your version of this library but this issue doesn't seem to be fixed, did I miss something? (I can't find a better way to comment to you than via the issue itself).