search

i7 / counterfeit-monkey

Counterfeit Monkey by Emily Short
http://ifdb.tads.org/viewgame?id=aearuuxv83plclpl
Other
164 stars 30 forks source link

Restore Fails #191

Closed purplepoet01 closed 2 years ago

purplepoet01 commented 2 years ago

Every time I try to restore a saved file, the site tells me restore failed. Not sure why.

angstsmurf commented 2 years ago

Thanks for reporting this! Which site is it you are playing on?

whatwhatwhatwhatwoahhh commented 2 years ago

I have the same problem. Im using the link from ifdb https://iplayif.com/?story=https%3A%2F%2Fgithub.com%2Fi7%2Fcounterfeit-monkey%2Freleases%2Fdownload%2Fr10%2FCounterfeitMonkey-10.gblorb

angstsmurf commented 2 years ago

Thanks!

I can't reproduce this, but I had problems in the past running out of disk space quota when running this in a browser.

What browser and OS is this? Did it happen the first time you tried to restore or did it use to work? Do you have a lot of saved positions?

curiousdannii commented 2 years ago

I can reproduce it, and there are improvements we can make to Parchment, but there's probably not really much to do on the CM side. The only thing would be to patch the save code to check for 0 bytes being written.

I wrote more at https://intfiction.org/t/counterfeit-monkey-restoring-fails-in-parchment/57013/2

curiousdannii commented 2 years ago

I have made it so that Parchment now encodes files in base32768 for localStorage, so you should be able to store about 7 times more data there now. This is live on iplayif.com and from what I can see everything is working properly. Let me know if you see any bugs.

I haven’t made it delete old autosaves, but I intend to look at that soon.

curiousdannii commented 2 years ago

@angstsmurf You could look at bringing in this code into CM, it should work in 6M62: https://github.com/ganelson/inform/pull/64

angstsmurf commented 2 years ago

I incorporated your fix. It would be nice if somebody could confirm that it is working.