i8enn / pydantic-odm

Small async ODM for MongoDB based in Motor and Pydantic library

MIT License

39 stars 8 forks source link

Minimum working connection settings #11

Closed hongquan closed 4 years ago

hongquan commented 4 years ago

On Linux, especially in development, authentication for local MongoDB is not needed to set. It help save effort of keeping secret info around. This PR allows to connect to a local MongoDB server with minimum settings.

codecov-io commented 4 years ago

Codecov Report

Merging #11 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files           2        2           
  Lines         141      141           
  Branches       28       28           
=======================================
  Hits          123      123           
  Misses          6        6           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b28850...77e7f0c. Read the comment docs.

i8enn commented 4 years ago

Hi, @hongquan! Thank you very much for your contribution to the project! Sorry for the long answer time: lately I have been overwhelmed with work, but I hope everything will return to normal after the new year.

Regarding the pull request - this is a good idea - i missed this problem (especially with the introduction of the authMechanism parameter).

I added of changing to your pull request, and also commented on the changed place - please check, and if everything is fine - tell me and I will apply these changes.

hongquan commented 4 years ago

@i8enn I agree with your addition.