i96751414 / plugin.video.torrest

Torrest plugin for Kodi
MIT License
27 stars 6 forks source link

Torrest 0.0.15 blows Kodi 18 on Android (and probably on Linux) #24

Closed lopezvg closed 1 year ago

lopezvg commented 1 year ago

It seems that the Libtorrest.so approach is not compatible with Kodi 18-Python 2.

I have tried replacing the /storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.torrest/resources/bin/android_arm/libtorrest.so with the torrest.0.0.3.android_arm binary and it works.

kodi.log

i96751414 commented 1 year ago

Linux should not fail due to this. It would be good to really understand why it doesn't work with Kodi 18 (if due to python2 vs 3 errors, or due to the shared lib not being supported on this Kodi version). Anyway, a quick fix for this would be choosing between shared lib or not depending on kodi version.

i96751414 commented 1 year ago

Next torrest release will allow forcing to torrest binary on android devices.

lopezvg commented 1 year ago

I have tested it and it works fine, but inssuficient. Since on installation or first run you do not force automatically to Torrest binary on Kodi 18, the user is facing a chicken and egg problem. Kodi blows BEFORE the user has time to access the setup to force the Torrest binary, so the user is doomed.

For Alfa users, I hace setup a patch to change the Torrest setting. The first run manages to chage the setup xml, although still blows, but the next run works fine.

i96751414 commented 1 year ago

I think that's not entirely correct. If you do a first run of the plugin or reset its settings, you are first asked to update the addon settings and only then it starts the deamon. Also, you can still set change the setting with torrest binary down, right?

lopezvg commented 1 year ago

In my case Kodi 18 updated automatically Torrest from verson 0.0.15 to 0.0.16. It said that Torrest was updated but it did not ask to update the Torrest setting to set the to binary, so the next run Torrest assumed to use libtorrest.so and blowed after few seconds. No chance to access the Torrest settings